Closed ssmirr closed 9 months ago
@ssmirr Thank you for these changes! I believe all of the issues identified by the tool are fixed in this branch: https://github.com/hyperledger/firefly/pull/1454
If you want to merge that branch into this one, I can approve and merge this branch.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d6578db
) 99.99% compared to head (e8b32fa
) 99.99%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@nguyer changes from https://github.com/hyperledger/firefly/pull/1454 are now merged into this branch. Thanks for the review!
issues that tool initially found seem to be fixed now 🎉 https://github.com/hyperledger/firefly/actions/runs/7921236477/job/21626078565?pr=1462#step:4:306
This Pull request:
docker_build.sh
to ensuremake docker
has a non-zero exist code when the build fails, and handle clean up the builderBoth of the changes above are implemented with the help of Trivy, an open source scanning tool from Aquasec. Trivy is RedHat certified, and is being used as the default container scanner on GitLab (according to this link)