Upgrade Ubuntu 20.04 - Githubissues

hyperledger / indy-node

The server portion of a distributed ledger purpose-built for decentralized identity.

https://wiki.hyperledger.org/display/indy

Apache License 2.0

687 stars 657 forks source link

Upgrade Ubuntu 20.04 #1667

Closed adenishchenko closed 3 years ago

sovbot commented 3 years ago

Can one of the admins verify this patch?

WadeBarnes commented 3 years ago

(ci) test this please

WadeBarnes commented 3 years ago

@adenishchenko, What is the relation of this PR to the one @ryMarsh44 started here; WIP: Ubuntu 20.04 upgrade?

WadeBarnes commented 3 years ago

@adenishchenko, Please edit the PR and target the ubuntu-20.04-upgrade branch as the destination.

WadeBarnes commented 3 years ago

@adenishchenko, Also if this PR is still a work in progress, please edit the PR and change it to a Draft PR until it is ready for final review.

adenishchenko commented 3 years ago

@WadeBarnes Thank you for notices! We are waiting for CD/CI Ubuntu 20.04 for indy-node now. I'll check a progress.

WadeBarnes commented 3 years ago

@ryMarsh44, @Toktar, @adenishchenko, What is the relationship between this PR and https://github.com/hyperledger/indy-node/pull/1652? Can https://github.com/hyperledger/indy-node/pull/1652 be closed in favor of this PR?

WadeBarnes commented 3 years ago

@ryMarsh44, @Toktar, @adenishchenko, @udosson, If I understand correctly, based on the Indy Contributors call today, this PR can be taken out of WIP status. Is that correct?

WadeBarnes commented 3 years ago

DCO Sign-off is missing from this commit; https://github.com/hyperledger/indy-node/pull/1667/commits/9959164eb02b0aac43110055a8e3f43c5e30587a

WadeBarnes commented 3 years ago

@ryMarsh44, @Toktar, @adenishchenko, @udosson, @askolesov, There are no GHA workflows in this PR. Is this PR still relying on the Jenkins pipelines for running it's tests? What needs to be done to integrate the GHA workflows into the 20.04 upgrade work?

askolesov commented 3 years ago

@WadeBarnes

PR duplicates: this is the main PR with upgrade work, #1652 can be closed I think.
WIP status: yes, it can be taken out of it.
CI: this PR doesn't rely on Jenkins because Jenkins is only for 16.04. We definitely need to merge CI/CD work for Ubuntu 20.04 here, but I don't see a PR. (Sorry for my confusing PR, I've just closed it)
Signature: I think it's better to fix it right before merge.

WadeBarnes commented 3 years ago

@WadeBarnes

Signature: I think it's better to fix it right before merge.

Yes, this needs to be fixed sooner than later.

askolesov commented 3 years ago

Seems that it's ready now. @WadeBarnes Could you review it one more time, please?

adenishchenko commented 3 years ago

Hello @WadeBarnes . Could you review this PR?

WadeBarnes commented 3 years ago

@Toktar, It looks like the code owner's file has not been updated on this branch yet. So you'll have to approve and merge.