Closed arsulegai closed 11 months ago
Overall, I like the document. However, I find the mix of project guidance and the document being a template for a SECURITY.MD file project difficult. As a maintainer, I think starting the project/repository specific document from this document will be hard to maintain. I recommend either a second document that is the template for a project, or putting the template at the bottom of the document, clearly delineated from the policy text. The advantage of a separate document is that as the template evolves, it is relatively easy to compare a projects current policy from the Hyperledger Foundation’s recommend template.
I think the template itself should be relatively short, have a pointer to the Hyperledger Foundation policy, and (as is used here) the highlighting to indicate where a project must make choices in their application of the secrity policy options.
@arsulegai I can make the edits I proposed above, but I think you first need to update the PR to "Allow edits from maintainers".
@arsulegai I can make the edits I proposed above, but I think you first need to update the PR to "Allow edits from maintainers".
Done @denyeart. I keep it disabled by default because it also shares the access to secrets.
Per the discussion last week, I've created a draft PR in the Aries ACA-Py repository that I think is an appropriate basis for a "template" project SECURITY.md
file. Note that in each section the discussion of options has been removed, and only the reasonable default for all projects is given. For Aries, there is no reason not to follow the defaults. As can be seen, I did leave in a description of the roles and responsibilities of the security team, along with a few other high level "security vulnerability reporting" notes.
To turn this into a template, I would:
Hyperledger Aries
references to Hyperledger PROJECT
For the policy document, I suggest changing the tone (where necessary) to be a policy document not a template, and having for each section of the template a discussion of the alternatives available for projects not wanting to follow the default.
Per the discussion last week, I've created a draft PR in the Aries ACA-Py repository that I think is an appropriate basis for a "template" project
SECURITY.md
file. Note that in each section the discussion of options has been removed, and only the reasonable default for all projects is given. For Aries, there is no reason not to follow the defaults. As can be seen, I did leave in a description of the roles and responsibilities of the security team, along with a few other high level "security vulnerability reporting" notes.To turn this into a template, I would:
- Convert all
Hyperledger Aries
references toHyperledger PROJECT
- Add a Markdown note pointing to the policy document section that describes the alternatives to the default available to projects such that they still adhere to the policy.
For the policy document, I suggest changing the tone (where necessary) to be a policy document not a template, and having for each section of the template a discussion of the alternatives available for projects not wanting to follow the default.
Thanks @swcurran , I agree your Aries SECURITY.md with some of the background discussion paragraphs removed is a more clear starting point for project visitors and a good basis for the SECURITY.md template. And I agree that the additional background discussion paragraphs should be included in a separate document that is linked from the SECURITY.md template. This will make the SECURITY.md more streamlined for project visitors, and easier for project maintainers to create based on the template with a simple copy/paste.
The more streamlined SECURITY.md also resolves my prior comments about making the use of Github vulnerability reporting clear. Specifically your version of the SECURITY.md template makes it clear that there are two equal options for reporting vulnerabilities - the security email and the use of Github vulnerability reporting.
Reworked in #167
Comments from the TOC meeting on 3rd August 2023:
TODO
activity.