search

hyperspy / exspy

EDS and EELS data analysis with HyperSpy
https://hyperspy.org/exspy
GNU General Public License v3.0
11 stars 10 forks source link

eelsdb blocks requests bugfix #66

Closed PauTorru closed 4 months ago

PauTorru commented 5 months ago

Description of the change

A few sentences and/or a bulleted list to describe and motivate the change:

Progress of the PR

Minimal example of the bug fix or the new feature

from exspy.misc.eels import eelsdb
s = eelsdb.eelsdb(spectrum_type="coreloss",element="O",edge="K")
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.47%. Comparing base (e63bd21) to head (7694c00). Report is 80 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== + Coverage 87.77% 88.47% +0.70% ========================================== Files 67 67 Lines 7286 7287 +1 Branches 1179 1179 ========================================== + Hits 6395 6447 +52 + Misses 626 571 -55 - Partials 265 269 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ericpre commented 5 months ago

pre-commit.ci autofix

PauTorru commented 5 months ago

Can you add a changelog entry as described in the pull request template: https://github.com/hyperspy/exspy/blob/main/.github/PULL_REQUEST_TEMPLATE.md

Like so? I edited first coment

ericpre commented 5 months ago

For the changelog entry, you need to add a rst file summarising the changes and with the correct name. This is explained in more detailed in upcoming_changes/README.rst.

Here is an example of a commit adding a changelog entry: https://github.com/hyperspy/exspy/pull/33/commits/bae38825badc9396e05eb6f16954eeba0684ec8f

The template is here as a guideline, which explains the main steps for contributors to know what they need to do but also as a reminder / check list (including experienced contributors 😄).

PauTorru commented 4 months ago

I think I got it now. Easy to tell it was my first contribution. 😅

ericpre commented 4 months ago

Thank you @PauTorru. There are a number of things to figure out when contributing the first time and it is not always easy to appreciate what is necessary or not, its relevance, etc.! :)