hyperspy / exspy

EDS and EELS data analysis with HyperSpy
https://hyperspy.org/exspy
GNU General Public License v3.0
11 stars 10 forks source link

Mention source of `elements` database in docstring #87

Closed ericpre closed 2 months ago

ericpre commented 2 months ago

As mentioned in https://github.com/hyperspy/exspy/discussions/85#discussioncomment-10678716.

Progress of the PR

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.70%. Comparing base (ee31d0a) to head (0f9d7c0). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ======================================= Coverage 88.70% 88.70% ======================================= Files 77 77 Lines 7453 7453 Branches 1200 1200 ======================================= Hits 6611 6611 Misses 572 572 Partials 270 270 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlaehne commented 2 months ago

Chantler reference is already mentioned in other docstrings, but way of mentioning is quite inconsistent.

ericpre commented 2 months ago

Chantler reference is already mentioned in other docstrings, but way of mentioning is quite inconsistent.

@jlaehne, is it better now with the references?

jlaehne commented 2 months ago

Chantler reference is already mentioned in other docstrings, but way of mentioning is quite inconsistent.

@jlaehne, is it better now with the references?

Maybe align also the citation in the Bibliography of the User Guide (use DOI, it currently uses the subtitle and not the title of the page).