hyperspy / exspy

EDS and EELS data analysis with HyperSpy
https://hyperspy.org/exspy
GNU General Public License v3.0
11 stars 10 forks source link

Fix import #90

Closed ericpre closed 1 month ago

ericpre commented 1 month ago

Progress of the PR

@CSSFrancis, @jlaehne, I think we should make a patch release straightaway since atomap is using one of these import.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.83%. Comparing base (62a32a3) to head (1f65ac5). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ======================================= Coverage 88.82% 88.83% ======================================= Files 77 77 Lines 7475 7476 +1 Branches 1024 1024 ======================================= + Hits 6640 6641 +1 Misses 568 568 Partials 267 267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlaehne commented 1 month ago

Would an intersphinx link to atomap in the changelog make sense or is that overkill?

ericpre commented 1 month ago

It did cross my mind and I thought that this isn't necessary: for new features, it is convenient, because it send to the relevant part of the documentation but here this is not the case.