hyperspy / hyperspy-bundle

The HyperSpy-bundle Distribution
https://hyperspy.org/hyperspy-bundle
GNU General Public License v3.0
9 stars 10 forks source link

Workaround to fix `get_current_hyperspy_version`. #22

Closed ericpre closed 6 years ago

ericpre commented 6 years ago

I gave a try at building a HyperSpy bundle on appveyor and there is this error with the get_current_hyperspy_version function. This PR is a workaround to fix the issue. I don't understand why this issue occurs, mainly because it was working before and according to the documentation it should work as it is currently... but I can reproduce it on python 3.5 on windows.

francisco-dlp commented 6 years ago

This PR does more than it advertises. The main issue LGTM, but the rest should go elsewhere.

ericpre commented 6 years ago

Yes, indeed, it was good value for money! More seriously, everything should be removed now.

ericpre commented 6 years ago

Can we get this merged, now that I have removed the other things? I need to make another PR to get the last winpython version working and adjust a few things for the changes related to jupyterlab!