Change permission installation folder

ericpre commented 5 years ago

[x] Change permission installation folder to "Full Access" for all users when installing with admin right to avoid poor performance when running python code without admin right,
[x] use NSIS from miniconda (nsis channel) to make the installation of plugin easier,
[x] remove python 3.6 bundle, since there is no problem with the last python 3.7 bundle,
[x] ready for review.

The log of the build on appveyor and the bundle itself.

ericpre commented 5 years ago

Tested manually on Win7 and Win10 with a install/uninstall cycle and it all works as expected.

francisco-dlp commented 5 years ago

Looks good except for the change of permissions of the installation folder. Without knowing much about Windows, I am concerned that this can pose a security risk. Even if it doens't, it also means that all users in a system can modify the hyperspy bundle installation, what may not be ideal in some cases. I would rather print a message explaining that HyperSpy may be slower to import when installing with admin rights due to the permissions issue and that the user can change manually the permissions to optimize the performance if required. In this way, if that causes a security issue or other annoyances, at least the user knows what he's doing.

ericpre commented 5 years ago

Closing this since the alternative fix in #37 is better.

hyperspy / hyperspy-bundle

Change permission installation folder #36