Closed robertknight closed 1 month ago
One issue I noticed: if a confirmation tick is shown next to the Save changes button because a previous change has already been saved, then changing the selected radio box doesn't clear the tick like changing one of the text fields does. This means you end up clicking Save changes when the tick is already still present which is a little weird.
One issue I noticed: if a confirmation tick is shown next to the Save changes button because a previous change has already been saved, then changing the selected radio box doesn't clear the tick like changing one of the text fields does.
Ah, the form's save state is not reset. I'll address this as part of https://github.com/hypothesis/h/pull/8994.
This allows setting the group type to "private", "restricted" or "open" when creating or editing a group.
This PR does not implement the part of the design where a warning is shown when changing the type of an existing group.
See https://github.com/hypothesis/h/issues/8898.
Testing:
group_type
feature flag