hypothesis / h

Annotate with anyone, anywhere.
https://hypothes.is/
BSD 2-Clause "Simplified" License
2.96k stars 427 forks source link

Add `/group/:pubid/edit/members` route and placeholder page in frontend #9075

Closed robertknight closed 1 week ago

robertknight commented 1 week ago

Add a route for editing group members and a placeholder page in the frontend. When the group_members feature flag is enabled, the group forms display a tab bar that allows the user to switch between the pages for editing group settings and group members.

Summary of changes:

Group edit view with new tab bar:

Edit group tab bar

"Members" tab placeholder:

Edit group members placeholder
robertknight commented 1 week ago

A known issue is that clicking the "Members" link doesn't warn if there are unsaved changes in the group settings form. I will address this in a follow-up.

robertknight commented 1 week ago

What are you planning to do if the URL is manually visited while the feature flag is disabled?

The user will see the membership management page, the same as if the flag was enabled. That's fine, since the purpose of the flag is just to hide the entry point in the main groups form.