Closed robertknight closed 1 week ago
A known issue is that clicking the "Members" link doesn't warn if there are unsaved changes in the group settings form. I will address this in a follow-up.
What are you planning to do if the URL is manually visited while the feature flag is disabled?
The user will see the membership management page, the same as if the flag was enabled. That's fine, since the purpose of the flag is just to hide the entry point in the main groups form.
Add a route for editing group members and a placeholder page in the frontend. When the
group_members
feature flag is enabled, the group forms display a tab bar that allows the user to switch between the pages for editing group settings and group members.Summary of changes:
/group/:pubid/edit/members
backend routegroup_members
feature flag to frontendAppRoot
) to the frontend entry point which switches the displayed component based upon the URL. This uses the same router that we use in the LMS frontend. This component also reads the JSON configuration and exposes it to child components via Preact context.GroupFormHeader
component which contains the "Settings" and "Members" links. These links trigger client-side transitions. This component is rendered byCreateEditGroupForm
component if thegroup_members
flag is enabled.Group edit view with new tab bar:
"Members" tab placeholder: