hypothesis / h

Annotate with anyone, anywhere.
https://hypothes.is/
BSD 2-Clause "Simplified" License
2.96k stars 427 forks source link

Add filter input to group members table #9102

Closed robertknight closed 2 days ago

robertknight commented 3 days ago

Add a search box to filter group members. The filter currently only matches the username, is applied client-side and is case-insensitive.

Filter not applied:

filter-empty

Filter applied with match:

filter-match

Filter applied with no matches:

filter-no-match
robertknight commented 3 days ago

In the client we have a SearchField component that has additional features compared to a plain input such as a search icon, support for focusing by pressing "/" and a "clear" button when non-empty. It might be useful to extract that into the shared library so we can use it here.

client-search-field
acelaya commented 3 days ago

In the client we have a SearchField component that has additional features compared to a plain input such as a search icon, support for focusing by pressing "/" and a "clear" button when non-empty. It might be useful to extract that into the shared library so we can use it here.

client-search-field

I believe we have something similar in via's video transcript app, so it definitely makes sense to extract a component that can be reused.

robertknight commented 2 days ago

The filtering and member count are currently implemented client side, but once we have pagination they will need to be implemented server-side. This means we will probably need to temporarily remove this until more critical functionality is implemented.