search

hyprwm / hyprland-plugins

Official plugins for Hyprland
BSD 3-Clause "New" or "Revised" License
521 stars 53 forks source link

hyprexpo: switching workspace while hyprexpo is open crashes Hyprland #112

Closed alba4k closed 6 months ago

alba4k commented 6 months ago

Pretty much what the title says (I'm using keyboard bindings)

hyprlandCrashReport174650.txt

vaxerski commented 6 months ago

you need to be more specific; it doesn't for me

alba4k commented 6 months ago

Doesn't crash anymore on my side either, may just be a random thing.

As before tho, it looks quite weird (Like, say I open it while on ws1 and then switch to ws2, I can't switch back to ws1). Is this the same on your machine?

vaxerski commented 6 months ago

yea it generally is buggy when you switch workspaces with a keybind. I might forcefully disable it, or make it close the overlay.

alba4k commented 6 months ago

both options make equally sense

throw a coin

or, if you wanna do it with style, close the overlay with the same animation that would play if you had clicked on the selected workspace (which I guess requires intercepting which workspace the bind was pointing to)

alba4k commented 6 months ago

Ok I think it just looks like the window from all workspaces are just being put into the same workspace

immagine

in this image I was on ws6 and tried switching to 1 2 and 3

Hyprland crashed once I tried to press on ws4 to switch to that.

edit: yup I can replicate that

hyprland crashed after clicking on some workspace while in this weird glitchrd state

vaxerski commented 6 months ago

if you wanna do it with style, close the overlay with the same animation that would play if you had clicked on the selected workspace (which I guess requires intercepting which workspace the bind was pointing to)

that's literally option 2

vaxerski commented 6 months ago

also crash this crash that but no crash report where crash report

vaxerski commented 6 months ago

thoughts?

alba4k commented 6 months ago

crash report is in the original issue lmao

also, lgtm, let me test that

alba4k commented 6 months ago

Works as almost perfectly, but the weird behavior is still visible if changing workspace again during the closing animation

https://github.com/hyprwm/hyprland-plugins/assets/84153269/711b07b4-a83f-4d8d-90de-f8cd1e1652a8

vaxerski commented 6 months ago

meh minor

alba4k commented 6 months ago

Agree, but I guess it deserved being pointed out.

alba4k commented 6 months ago

Agree, but I guess it deserved being pointed out.