search

hyyan / woo-poly-integration

Looking for maintainers! - Wordpress WooCommerce Polylang Integration
https://wordpress.org/plugins-wp/woo-poly-integration/
MIT License
183 stars 66 forks source link

Wrong meta value and bad JS #518

Closed edgarmirandasilva closed 4 years ago

edgarmirandasilva commented 4 years ago

I think all the problems with variations products are now solved.

Updated V2.8.3 Polylang

Hyyan WooCommerce Polylang Integration 1.4.3 with the fixes from this commit

On Polylang Settings

2020-10-17_15h12_08

Was _translation_porduct_type Is _translation_product_type

This pull request fixes #.

What's Included in This Pull Request

mrleemon commented 3 years ago

@edgarmirandasilva In your PR you changed the meta name _translation_porduct_type to _translation_product_type in src/Hyyan/WPI/Plugin.php. This misspelling cannot be "fixed" because there are references to this misspelled meta in other files of the plugin (src/Hyyan/WPI/Product/Meta.php) AND products already in the DB use the misspelled meta name, so this change screws them up.

In order to change this meta name, a batch process should be included to change all these misspelled metas already in the DB, so I don't think it's worth changing it.