hyyan / woo-poly-integration

Looking for maintainers! - Wordpress WooCommerce Polylang Integration
https://wordpress.org/plugins-wp/woo-poly-integration/
MIT License
183 stars 66 forks source link

translateEmailStringToOrderLanguage / translateEmailStringToObjectLanguage compatibility issue for WooCommerce Germanized #540

Closed kamran1331 closed 3 years ago

kamran1331 commented 3 years ago

2021-02-21T00:48:24+00:00 CRITICAL Uncaught Error: Call to undefined method Hyyan\WPI\Emails::translateEmailStringToOrderLanguage() in /www/htdocs/*/***/wp-content/plugins/woocommerce-germanized/includes/compatibility/class-wc-gzd-compatibility-woo-poly-integration.php:135 Stack trace:

0 /www/htdocs/*/***/wp-includes/class-wp-hook.php(289): WC_GZD_Compatibility_Woo_Poly_Integration->translate_order_subject('Zahlung erhalte...', Object(Automattic\WooCommerce\Admin\Overrides\Order))

1 /www/htdocs/**/a***/wp-includes/plugin.php(212): WP_Hook->apply_filters('Zahlung erhalte...', Array)

2 /www/htdocs/**/a***/wp-content/plugins/woocommerce/includes/emails/class-wc-email.php(381): apply_filters('woocommerce_ema...', 'Zahlung erhalte...', Object(Automattic\WooCommerce\Admin\Overrides\Order), Object(WC_GZD_Email_Customer_Paid_For_Order))

3 /www/htdocs/**/a****e/wp-content/plugins/woocommerce-germanized/includes/emails/class-wc-gzd-email-customer-paid-for-order.ph in /www/htdocs/***/****/wp-content/plugins/woocommerce-germanized/includes/compatibility/class-wc-gzd-compatibility-woo-poly-integration.php in Zeile 135

mrleemon commented 3 years ago

This is an error coming from the WooCommerce Germanized plugin.

In their class-wc-gzd-compatibility-woo-poly-integration.php file there are two references to a function that has been renamed in WooPoly.

return $this->get_pll_email_instance()->translateEmailStringToOrderLanguage( $subject, $object, 'subject', $email_id );

should be changed to:

return $this->get_pll_email_instance()->translateEmailStringToObjectLanguage( $subject, $object, 'subject', $email_id );

And:

return $this->get_pll_email_instance()->translateEmailStringToOrderLanguage( $heading, $object, 'heading', $email_id );

should be changed to:

return $this->get_pll_email_instance()->translateEmailStringToObjectLanguage( $heading, $object, 'heading', $email_id );

kamran1331 commented 3 years ago

thanks, this is next bug for me :D

i hope the problem with Klarna can be solved.

Mit freundlichen Grüßen Nuriyev

Am So., 21. Feb. 2021 um 22:57 Uhr schrieb mrleemon < notifications@github.com>:

This is an error coming from the WooCommerce Germanized plugin.

In their class-wc-gzd-compatibility-woo-poly-integration.php file there are two references to a function that has been renamed in WooPoly.

return $this->get_pll_email_instance()->translateEmailStringToOrderLanguage( $subject, $object, 'subject', $email_id );

should be changed to:

return $this->get_pll_email_instance()->translateEmailStringToObjectLanguage( $subject, $object, 'subject', $email_id );

And:

return $this->get_pll_email_instance()->translateEmailStringToOrderLanguage( $heading, $object, 'heading', $email_id );

should be changed to:

return $this->get_pll_email_instance()->translateEmailStringToObjectLanguage( $heading, $object, 'heading', $email_id );

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hyyan/woo-poly-integration/issues/540#issuecomment-782934415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4O5CC6EQRT6UI4VW7ID4TTAF6VXANCNFSM4X7KXFNA .

kamran1331 commented 3 years ago

sorry false email...

ok, i will write to the Germanized Plugin. for update. Thank you.

Mit freundlichen Grüßen Nuriyev

Am So., 21. Feb. 2021 um 23:01 Uhr schrieb Kamran Nuriyev < nuriyev.1331@gmail.com>:

thanks, this is next bug for me :D

i hope the problem with Klarna can be solved.

Mit freundlichen Grüßen Nuriyev

Am So., 21. Feb. 2021 um 22:57 Uhr schrieb mrleemon < notifications@github.com>:

This is an error coming from the WooCommerce Germanized plugin.

In their class-wc-gzd-compatibility-woo-poly-integration.php file there are two references to a function that has been renamed in WooPoly.

return $this->get_pll_email_instance()->translateEmailStringToOrderLanguage( $subject, $object, 'subject', $email_id );

should be changed to:

return $this->get_pll_email_instance()->translateEmailStringToObjectLanguage( $subject, $object, 'subject', $email_id );

And:

return $this->get_pll_email_instance()->translateEmailStringToOrderLanguage( $heading, $object, 'heading', $email_id );

should be changed to:

return $this->get_pll_email_instance()->translateEmailStringToObjectLanguage( $heading, $object, 'heading', $email_id );

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hyyan/woo-poly-integration/issues/540#issuecomment-782934415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF4O5CC6EQRT6UI4VW7ID4TTAF6VXANCNFSM4X7KXFNA .

mrleemon commented 3 years ago

Apparently, this has been fixed in WooCommerce Germanized 3.3.7: https://es.wordpress.org/plugins/woocommerce-germanized/#developers

Jon007 commented 3 years ago

I see that's 8 releases ago for WooCommerce Germanized so I think we can close here then.