Closed hzovaro closed 4 months ago
@hzovaro i would like to try, please assign me this issue
Sorry @n-keerthi-gayathri, I can't see anything in your profile that suggests you are familiar with integral field unit data sets - I would prefer for someone familiar with handling this sort of data to contribute.
apply_cuts
is called?make_sami/hector/s7/etc._df()
that could be replaced with a single generic function that is passed the appropriate_process_gals
call fromsami/hector/s7.py
(see #48)D4000 error
< 0?x, y (pixels)
as it's not really necessary and creates problems with object data types in DataFramescompute_eline_luminosity
andcompute_continuum_luminosity
remove the hard-coded factor of 1e16 - replace this with aflux_units
arg and createflux_units
entries for surveys inconfig.json
flux_units
variable to the loader functionsExtinction correction applied
tocorrect_extinction
missing_kinematics_cut
wasn't being added to the DataFrame inadd_columns()
Columns to rename:
x0_px
-->x0 (pixels)
, etc. in all filesDopita+2016
-->N2S2Ha
~Dopita+2016
refers to a specific polynomial form of the ratio so it doesn't make sense to do thisHALPHA lambda_obs (component 1) (Å)
-->HALPHA lambda_obs (Å) (component 1)
For renaming:
sami_regression_test.py
. Modify it to print out which columns have changed (& double-check that assertion tests still work).