search

i18next / i18next-parser

Parse your code to extract translation keys/values and manage your catalog files
MIT License
477 stars 195 forks source link

Remove VueLexer #1007

Closed jolson474 closed 3 months ago

jolson474 commented 4 months ago

Why am I submitting this PR

While investigating how to run i18next-parser on a vue3 code base, I came across this ticket which suggested simply removing VueLexer, which would also eliminate the dependency issues with vue-template: https://github.com/i18next/i18next-parser/issues/617

After trying it, this change seemed to meet my needs very nicely, so I thought I would contribute it back to make things easier for other folks using Vue3 (and dropping support for Vue2 didn't seem like it would be a very surprising change going forward).

In addition to removing VueLexer from the code (and its tests) I also updated the documentation and bumped the version to 9.0 since this is a breaking change. The migration documentation is updated to reflect that you need to remove VueLexer from any configuration files as well.

Let me know if you have any concerns/questions with this approach. Thanks!

Does it fix an existing ticket?

Yes #617

Checklist

socket-security[bot] commented 4 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/vue-template-compiler@2.7.16

View full report↗︎

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.32%. Comparing base (7e14d85) to head (a0a960c). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1007 +/- ## ========================================== + Coverage 95.16% 95.32% +0.16% ========================================== Files 11 10 -1 Lines 1922 1905 -17 ========================================== - Hits 1829 1816 -13 + Misses 93 89 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karellm commented 3 months ago

Thank you! It is now in 9.0.0