search

i7MEDIA / mojoportal

mojoPortal is an extensible, cross database, mobile friendly, web content management system (CMS) and web application framework written in C# ASP.NET.
https://www.mojoportal.com
Other
197 stars 100 forks source link

Some images break Better Image Gallery #218

Open joeystombaugh opened 1 year ago

joeystombaugh commented 1 year ago

something else When uploading the above image to better image gallery it gives an aw shucks. Checking the error log I got 

System.OutOfMemoryException: Out of memory.
   at System.Drawing.Image.FromFile(String filename, Boolean useEmbeddedColorManagement)
   at mojoPortal.Features.UI.BetterImageGallery.BetterImageGalleryService.CreateThumbnails(FileInfo[] images, String thumbnailCachePath)
   at mojoPortal.Features.UI.BetterImageGallery.BetterImageGalleryService.SetupThumbnails()
   at mojoPortal.Features.UI.BetterImageGallery.BetterImageGalleryRazor.RenderContents(HtmlTextWriter output)
   at System.Web.UI.WebControls.WebControl.Render(HtmlTextWriter writer)

It is definitely an issue with the image but better image gallery should silently fail and not break like that.

JosephMDavis commented 1 year ago

turns out the images in question were webp saved as jpg and that was causing System.Drawing to have issues. We should still catch the error gracefully.