First things first. Welcome to the repo and thank you for submitting you Pull Request!
What you see now is a merge request template. Please remove these two paragraphs and fill in the sections below.Writing the merge request description helps to share your code faster)
TL;DR
Please explain in one line what is this merge request about
Proof
(before we let the code in, we would like to know it works. You already tested the change so why not document it and show the others as well?Examples: picture of the Networks tab showing the requests, animated gif, short video).
Merge request checklist
Please check if your merge request fulfills the following requirements:
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been reviewed and added/updated if needed (for bug fixes/features)
[ ] Build (yarn build) was run locally and any changes were pushed for both API and clients
[ ] API (yarn api:dev) runs locally and any fixes were made for failures
[ ] Admin Client (cd clients/admin && yarn start) runs locally and any fixes were made for failures
Merge request type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no APIoduce changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
Before this merge request
(describe what was the code state before the MR and what is the current behavior.Examples: The /products API client was missing and is needed for further development)
How you fixed what was wrong
(this is the most important part of the MR description.We already know what was wrong and if we read the issue connected we know where you want to get.Looking at the code we will also know what you wrote. So please explain why you did it this way.Examples: I decided to keep the list of the blembas in the store as we use it on more occasions in the application.)
First things first. Welcome to the repo and thank you for submitting you Pull Request!
What you see now is a merge request template. Please remove these two paragraphs and fill in the sections below. Writing the merge request description helps to share your code faster)
TL;DR
Please explain in one line what is this merge request about
Proof
(before we let the code in, we would like to know it works. You already tested the change so why not document it and show the others as well? Examples: picture of the Networks tab showing the requests, animated gif, short video).
Merge request checklist
Please check if your merge request fulfills the following requirements:
yarn build) was run locally and any changes were pushed for both API and clientsyarn api:dev) runs locally and any fixes were made for failurescd clients/admin && yarn start) runs locally and any fixes were made for failuresMerge request type
Before this merge request
(describe what was the code state before the MR and what is the current behavior. Examples: The
/productsAPI client was missing and is needed for further development)How you fixed what was wrong
(this is the most important part of the MR description. We already know what was wrong and if we read the issue connected we know where you want to get. Looking at the code we will also know what you wrote. So please explain why you did it this way. Examples: I decided to keep the list of the blembas in the store as we use it on more occasions in the application.)