search

iFelix18 / Darkerr

A darker theme for Sonarr, Radarr & Lidarr
https://git.io/Darkerr
Creative Commons Attribution Share Alike 4.0 International
40 stars 2 forks source link

Sonarr V3 updated broken style #17

Open JourneyOver opened 5 years ago

JourneyOver commented 5 years ago

Been using the dev branch of darkerr since I've been using the V3 release of sonarr, and it's been working great and all, but looks like an update (either release 3.0.1.384 or the recent one 3.0.1.388) hit and has changed some CSS around, as the style is pretty much borked now xD

Just thought I'd let ya know :p

chrome_03-05-2019_15-48-37 03-05-2019_15-51-11

Dunno what all is broken, but those two above are the most evident for sure.

iFelix18 commented 5 years ago

Yeah, I noticed. According to the forum the classes are generated automatically, and it is not excluded that they can change again in the future.

For example old class : .SeriesIndexPoster-title-1LWvk new class : .SeriesIndexPoster-title-263Pq

To avoid future break I should update my theme entirely with classes like: [class^='SeriesIndexPoster-title']

It will take a bit 'of time...

JourneyOver commented 5 years ago

Ah wow, figured that's probably what they where doing but I never really looked much into the CSS of sonarr especially for v3 xD it's pretty much the same thing plex does though as well and the reasoning on why I use the whole [class^='whatever'] system for it.

iFelix18 commented 5 years ago

Darkerr 3.0.0-beta8 has been released. It should solve every problem with the new Sonarr updates, I await feedbacks.

JourneyOver commented 5 years ago

@iFelix18 Looks good, everything seems to be back to working order again and nothing seems to be messed up from my quick look through. Also why did you delete your jackett theme or are you moving it to it's own repository?

iFelix18 commented 5 years ago

Also why did you delete your jackett theme or are you moving it to it's own repository?

It was more like a test, it was never even complete, and it never left the develop branch. I consider Jackett a "background service", I use very little Jackett's UI once configured in Sonarr and other -rr services. So I decided to remove the theme for Jackett, and let Darkerr return what it was, a dark theme only for the -rr services.

JourneyOver commented 5 years ago

Ahh okay, anyways guess this issue can be closed now (will close it with this comment) since latest dev looks to have taken care of everything so far.

JourneyOver commented 5 years ago

Just going to re-open this issue:

Looks like CSS has changed again in version 3.0.2.549, not as broken as before as text is actually readable but it's no longer fully themed.

chrome_07-28-2019_21-56-22 chrome_07-28-2019_21-56-37

arogl commented 5 years ago

I'll add some more shots:

http://localhost:8989/calendar - the days of the week in calendar view image

Popup box when clicking on a show on the calendar screen image

Popup box on clicking manual import image

On a show screen image

Most popups

I'm not sure how often this will happen, but I notice they are considering a default dark css - prompted by @iFelix18

JourneyOver commented 5 years ago

but I notice they are considering a default dark css - prompted by @iFelix18

This would actually be nice, then we wouldn't have to worry about things breaking like this.

iFelix18 commented 5 years ago

Thanks, I'll take a look in the next few days.

iFelix18 commented 5 years ago

I took a look. Every single class has changed, it will take a bit of time, it's a long and boring job... it's getting hard to keep this theme with all these updates.

JourneyOver commented 5 years ago

Pretty much how it is with me and Plex as well xD They make it hard to keep a theme going with the updates that they pull out of their ass that ends up changing so much sometimes :/

arogl commented 5 years ago

I have installed dark reader, out of the box it does a pretty good job of having a dark style for Sonarr.