search

iGEM-Engineering / iGEM-distribution

Repository for collective design of an iGEM DNA distribution
https://igem-distribution.readthedocs.io
Other
42 stars 20 forks source link

Merge materials between import and Excel definition #131

Open jakebeal opened 3 years ago

jakebeal commented 3 years ago

Right now when we have an imported part, it's assumed that the imported part has more and more definitive information than the Excel does.

We should actually be merging the two sets of information so that the Excel can fill in gaps in the imported parts.

Example: https://github.com/iGEM-Engineering/iGEM-distribution/blob/6675ed9905aed3b43507129b1ea3fc3d3c8c75b1/iGEM%20Interlab%20Devices/README.md

jakebeal commented 2 years ago

This will likely be solved in two stages: 1) Merge when one is missing information 2) Think carefully about what we want to do with potentially conflicting information

This issue should be used for the first, and when that's done, we can split out a second.

jakebeal commented 2 years ago

A special case that we need ASAP is to use the role from the Excel sheet when the role in the file is the "I give up" default of: `SO:engineered_region (accessed in Python via tyto.SO.engineered_region)

jakebeal commented 2 years ago

Special case has been addressed in https://github.com/iGEM-Engineering/iGEM-distribution/pull/171 Larger issue remains.