search

iGitScor / critical-webpack-plugin

Webpack wrapper for critical css extraction
MIT License
3 stars 1 forks source link

Include generated critical css in assets list in webpack #15

Closed iGitScor closed 7 years ago

iGitScor commented 7 years ago

Pull request

Proposal

What kind of change does this PR introduce?

This plugin is now suitable with wepback flow ! πŸŽ‰ πŸ˜„ Files are generated at emit step in webpack build and can be modified or used by other plugins.

Did you add tests for your changes?

Yes. I also add node v4.x compatibility ❀️

Summary

Generated css is not included in the assets list and cannot be modified by other plugins.

Other information

Issue: #14

GIF

Perfect

codecov-io commented 7 years ago

Codecov Report

Merging #15 into master will decrease coverage by 12.12%. The diff coverage is 69.23%.

@@             Coverage Diff             @@
##           master      #15       +/-   ##
===========================================
- Coverage     100%   87.87%   -12.13%     
===========================================
  Files           1        1               
  Lines          29       33        +4     
  Branches        3        4        +1     
===========================================
  Hits           29       29               
- Misses          0        4        +4
Impacted Files Coverage Ξ”
index.js 87.87% <69.23%> (-12.13%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update aed487f...65104f1. Read the comment docs.