One need to think whether we want this steering parameter at all?
The (0, 0, 0) seems only reasonable point one would use for this.
Another reasonable option is to use last tracker hit as a vertex.
But this changes from event to event, from pfo to pfo.
So one would need to implement it in the code, not like as a steering parameter...
I would propose to remove it as confusing and irrelevant...
dudarboh
commented
3 years ago
DDSpaceBuilderhas steering parameters:https://github.com/iLCSoft/MarlinTrkProcessors/blob/0c06ad16983b6cba545d561c5d8a5b43bcebce6d/source/Digitisers/src/DDSpacePointBuilder.cc#L69-L84
which are used only to define
_nominal_vertexwhich isn't used in the processor at all. https://github.com/iLCSoft/MarlinTrkProcessors/blob/0c06ad16983b6cba545d561c5d8a5b43bcebce6d/source/Digitisers/src/DDSpacePointBuilder.cc#L119I assume from the description it was supposed to be used in the vertex here: https://github.com/iLCSoft/MarlinTrkProcessors/blob/0c06ad16983b6cba545d561c5d8a5b43bcebce6d/source/Digitisers/src/DDSpacePointBuilder.cc#L502
One need to think whether we want this steering parameter at all?
The
(0, 0, 0)seems only reasonable point one would use for this. Another reasonable option is to use last tracker hit as a vertex. But this changes from event to event, from pfo to pfo. So one would need to implement it in the code, not like as a steering parameter...I would propose to remove it as confusing and irrelevant...