iNavFlight / inav

INAV: Navigation-enabled flight control software
https://inavflight.github.io
GNU General Public License v3.0
3.11k stars 1.47k forks source link

Land after RTH - delayed landing. #6173

Closed PR31D closed 6 months ago

PR31D commented 3 years ago

Current Behavior

As expected. On the craft returning home it immediately begins to land.

Desired Behavior

On the craft returning to home, if it could loiter a set amount of time before starting to land.

Suggested Solution

Add in a variable delay where the craft will loiter before starting to land.

Who does this impact? Who is this for?

This is mainly for fixed wing that dont crash well. I fly lion long range and I cant have my failsafe set to RTH and loiter as it could be up there loitering for a long time. However if im at short range and I've an issue with the link, the wing will start to land immediately on return to home. Not giving me any time to try sort the link out.

Additional context

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the label BUG to this issue, with a confidence of 0.69. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

PR31D commented 3 years ago

👎

MrD-RC commented 3 years ago

This is an excellent idea for pilots who fly from a site unsuitable for auto landing. It will give time to try and fix problems, knowing that the model is safe above them.

PR31D commented 3 years ago

Hi Darren,

Thanks for the feedback.


From: Darren Lines notifications@github.com Sent: 26 October 2020 08:06 To: iNavFlight/inav inav@noreply.github.com Cc: PR31D distortion@hotmail.co.uk; Author author@noreply.github.com Subject: Re: [iNavFlight/inav] Land after RTH - delayed landing. (#6173)

This is an excellent idea for pilots who fly from a site unsuitable for auto landing. It will give time to try and fix problems, knowing that the model is safe above them.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FiNavFlight%2Finav%2Fissues%2F6173%23issuecomment-716382789&data=04%7C01%7C%7C9b3c33f0a07d49d65d1408d87985fae2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637392963623721717%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7uDrvL9b1nMCWO1Rym%2BZkAlnxR7Zoz2oYp4Py711%2Bd8%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQSMJZ445XRW7MJ6E3DKU3DSMUUWTANCNFSM4SDWIUIA&data=04%7C01%7C%7C9b3c33f0a07d49d65d1408d87985fae2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637392963623731713%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=S0uGMGy3womsjEWsoMZHUVBc9zXwZekyRsbBk1f4bcI%3D&reserved=0.

MrMap commented 3 years ago

Very good that this is merged into new versions. Here is a video illustrating a CFIT (Controlled Flight Into Terrain) ending of a test flight otherwise sussesful (ending with a FS test). On a side note my fixedwing "landed" on cruise throttle, despite _set failsafe_throttle = 1000 (I will submit an issue on this).

Had this new landing delay functionality been in place I would not have to use so much glue. That said I am painfully aware that this was all on me, not having thought it through properly (FS test procedure). Enjoy the video! https://youtu.be/9HkOczusHDI

b14ckyy commented 6 months ago

Should be no issue anymore with https://github.com/iNavFlight/inav/pull/9713 Additional features are planned for the near future, for example only autoland with defined landing spots but to avoid circle landing. Will keep this open for now.

b14ckyy commented 6 months ago

Oh here we go, its implemented. Closing https://github.com/iNavFlight/inav/blob/master/docs/Settings.md#nav_rth_fs_landing_delay