search

iPortalTeam / ImmersivePortalsMod

Non-Euclidean in Minecraft. See through portals and teleport seamlessly.
https://qouteall.fun/immptl/
Apache License 2.0
421 stars 100 forks source link

Incompatible wity Axiom #1542

Open DivergentPayar opened 3 months ago

DivergentPayar commented 3 months ago

Is it a mod compatibility issue?

Yes

If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)

https://modrinth.com/mod/axiom

Minecraft version

1.20.4

Describe the issue

Due to the way Immersive Portals modifies chunk data packets, when in editor mode for 'Axiom', you need to relog in order to see any changes that occur.

Moulberry commented 1 month ago

This is the packet being sent: https://github.com/Moulberry/AxiomPaperPlugin/blob/master/src/main/java/com/moulberry/axiom/WorldExtension.java#L134

If there's any additional information you need from my side just let me know

qouteall commented 1 month ago

@Moulberry iPortal redirects packet to attach dimension id. If raw vanilla packet is sent, then it will be handled as current player's dimension's packet and won't be handled in the correct dimension. This is hard to fix unless Axiom add iPortal as dependency and send redirected packet, which require a lot of modification of Axiom side.

Moulberry commented 1 month ago

The changes that are being done are happening in the same world as the player. If I understand correctly, it should be fine to handle the packet in the same dimension as the player.

The original bug report doesn't go into much detail, but essentially the chunk change packet is being completely ignored by the client. No block changes are applied when immptl is installed.

If you have information on what code in immptl might be responsible, I can take another look and work on a pull request