Datapack custom portals not loading

ArgenNova commented 1 year ago

According to your testing, does the issue occur with ONLY Immersive Portals mod installed?

Yes

Forge Version

43.3.5

ImmersivePortals Version

2.3.5-mc1.19.2

Latest Log

https://gist.github.com/ArgenNova/16af933941f6a846da07d91718af6f11#file-latest-log

Crash Report (if applicable)

No response

Steps to Reproduce

Create new world
Make special nether portal as defined in example datapack
Throw quartz in lava to trigger portal generation

What You Expected

New nether portal to generate

What Happened Instead

Nothing

Additional Details

This was attempted using the example datapack from the immersive portals site: example_custom_portal_gen.zip

Please Read and Confirm The Following

[X] I have confirmed this bug can be replicated without the use of Optifine.
[X] I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
[X] I have confirmed this does not happen on the fabric version (If it does please report to here instead).
[X] I have confirmed I'm not using a hybrid server (Magma, Cauldron) or a different (non official) Forge Server release.
[X] I have confirmed this issue is unique and has not been reported already.

ArgenNova commented 1 year ago

I forgot to mention: I did make sure that the datapack was added to the world and enabled when I created the world for testing

TecmagDiams commented 12 months ago

Just adding a +1 to this as well as confirmation that Nick1st is aware based on conversations from the Discord server the day after this issue was opened.

Not sure if anything else has been found out thus far but I'll be keeping an eye here as this is the one feature that has me ready to do another playthrough of modded Minecraft.

ArgenNova commented 12 months ago

I've been looking into this in my own time and actually got it working. It appears that the issue was registryRegistryKey in CustomPortalGeneration. It works if you drop the "imm_ptl" namespace from the location.

ArgenNova commented 12 months ago

Although I'm not sure if doing this may cause other issues that I didn't find while testing the fix.

ArgenNova commented 12 months ago

I do remember stumbling upon a comment from Forge in the MDK about needing to allow non-vanilla registry namespaces in the future. So it may also be fixed in a forge update down the line.

Ninzer0 commented 11 months ago

what do you mean by "drop the 'imm_ptl' namespace from the location"? i wanna get mine working and i do not understand. an example would help. do you mean like remove the imm_ptl from the generation files? like instead of "imm_ptl:any_dimension" just do "any_dimension"?

ArgenNova commented 11 months ago

Screenshot 2023-12-01 100956 This value here. Found in this class

TecmagDiams commented 11 months ago

what do you mean by "drop the 'imm_ptl' namespace from the location"? i wanna get mine working and i do not understand. an example would help. do you mean like remove the imm_ptl from the generation files? like instead of "imm_ptl:any_dimension" just do "any_dimension"?

They mean in the file imm_ptl_core/src/main/java/qouteall/imm_ptl/core/portal/custom_portal_gen/CustomPortalGeneration.java to remove imm_ptl: from line 52.

Unfortunetly I can't get the project to build and that's mostly from having no know how on building mods haha.

Nick1st commented 8 months ago

This has been fixed a while ago. I suppose it's working now? If not, feel free to reopen.

iPortalTeam / ImmersivePortalsModForForge