Closed AsierGonzalez closed 3 years ago
After checking how the workflows are integrated in the OpenEBench framework I suggest that we go for the simple solution of replacing "TCGA" with "APAeval" in the code, as trying to use the community_id
variable has some unwanted consequences that require further changes.
Same for the date, just update it with a more current date of your choice.
Thanks, Asier! I have changed TCGA
to APAeval
and the data to 2021-06-04: https://github.com/yuukiiwa/APAeval-summary-workflow/commit/78930e05d0903d2245e2668529eaa93a9c178de7
Fantastic, thank you @yuukiiwa!
The changes had the desired effect - I'm closing the ticket. Thank you for the great work @yuukiiwa!
The
_id
of the aggregation object contains two hardcoded parts that are outdated. Although they do not cause any issues, it would be good for them to have meaningful and updated values.This value is given in line 83 of manage_assessment_data.py:
APAeval
in there.DEFAULT_eventMark
embedded in the id is defined in the script and it contains a date - currently2018-04-05
. This date should be shared by all the runs of the same tool, so it is a configuration parameter that should probably go in main.nf. Again, as a temporary solution it could be hardcoded to something like '2021-06-04'.