search

iTwin / appui

Monorepo for iTwin.js AppUi
MIT License
9 stars 2 forks source link

Fixed `pw:` links handling in property grid #1091

Closed saskliutas closed 1 month ago

saskliutas commented 1 month ago

Changes

Fixed pw: links handling in property grid. They stopped working after latest chromium updates. Suggested solution is to use custom schema links with opaque paths: schema:<path> instead of schema://<path> https://docs.google.com/document/d/1LjxHl32fE4tCKugrK_PIso7mfXQVEeoD1wSnX2y0ZU8/edit?resourcekey=0-d1gP4X2sG7GPl9mlTeptIA&tab=t.0#heading=h.kjrmsvcywm3o

Also unified links handling between default property grid action and url property renderer.

Closes https://github.com/iTwin/appui/issues/1089

Testing

Tested manually with different browsers

saskliutas commented 1 month ago

@Mergifyio backport release/4.17.x

mergify[bot] commented 1 month ago

backport release/4.17.x

✅ Backports have been created

* [#1092 Fixed `pw:` links handling in property grid (backport #1091)](https://github.com/iTwin/appui/pull/1092) has been created for branch `release/4.17.x` but encountered conflicts
GerardasB commented 3 weeks ago

@Mergifyio backport release/5.0.x

mergify[bot] commented 3 weeks ago

backport release/5.0.x

✅ Backports have been created

* [#1103 Fixed `pw:` links handling in property grid (backport #1091)](https://github.com/iTwin/appui/pull/1103) has been created for branch `release/5.0.x`