ia-dev / opensimQt

CPP GUI for OpenSim
Apache License 2.0
5 stars 6 forks source link

MS0105: reload current scene function. #5

Closed idhamari closed 4 years ago

idhamari commented 4 years ago

Notes:

idhamari commented 4 years ago

Notice that all IO and critical code should be placed in error handling block that produces reasonable error in the application output and the application log.

yasseerr commented 4 years ago

HI! Check this milestone in the latest master commit the pop up is added but do you want to implement the functions of the popup on this milestone?

idhamari commented 4 years ago

Well done!

the pop up is added but do you want to implement the functions of the popup on this milestone?

Is it complicated? I thought you just call the reload function.

I will test the code and give feedback if need.

idhamari commented 4 years ago

Just tested it, everything works. If calling the reload function from the popup menu is complicated, you may ignore it for now and close the issue.

yasseerr commented 4 years ago

call the reload function it is all the functions like(add Prob,Add Marker,Display, Toggle Parent Frame ...)it is not complicated but it require the work from the Visualizer functions Milestone like linking the visualizer and Navigator and Navigator element popup menus ...

idhamari commented 4 years ago

Ok, I understand what is the problem now. The reload function should reload only one object, when it is called from the menu or F5, it should reload everything,

Another approach is something like this:

                reload( ....,std::string object_name ){
                try{
                if object_name is in the navigator tree:
                   reload this object 
                } else{
                  reload everything
                }
               }
yasseerr commented 4 years ago

i did not get it. The Current Reload Action reload everything when it called from the file that you described OpenSim.vs For the New Reload Function on the popup menu you want it to reload just the Selected Model ? Notice that all the model are present in the Navigator Tree

idhamari commented 4 years ago

It ok, you may ignore this for now. This issue is now closed.