search

iamfmjk / etsy

A friendly Ruby interface to the Etsy API
https://github.com/kytrinyx/etsy
MIT License
171 stars 113 forks source link

Add options to listing#variations, which requires oauth #108

Closed bytheway closed 8 years ago

bytheway commented 8 years ago

listing#variations current returns [] when called as:

user = Etsy.myself(token, secret)
shop = user.shop
listing = shop.listings[0]
listing.variations

Getting variations for a listing require oauth credentials to be passed:

https://www.etsy.com/developers/documentation/reference/variations_property#method_getlistingvariations

This adds an options argument to the variations method to allow passing in authentication:

access = {access_token: 'token', access_secret: 'secret'}
listing.variations(access)

Fixes #107

kytrinyx commented 8 years ago

Thank you!

This is having trouble installing dependencies on Travis CI. I can't see how this would be related to anything you did. I won't be able to debug this until the weekend, unfortunately.

kytrinyx commented 8 years ago

Sorry it's taken so long to get back to you on this. I'm looking into the problem now.

kytrinyx commented 8 years ago

Merged via #110

Thank you for the fix!