search

iamkroot / trakt-scrobbler

Scrobbler for trakt.tv that supports VLC, Plex, MPC-HC, and MPV.
https://github.com/iamkroot/trakt-scrobbler/wiki
GNU General Public License v2.0
468 stars 30 forks source link

cleo: Add compatibility wrapper for v1 #216

Closed ahmubashshir closed 2 years ago

ahmubashshir commented 2 years ago

Closes #215 Signed-off-by: Mubashshir ahmubashshir@gmail.com

ahmubashshir commented 2 years ago

@iamkroot how about this?

ahmubashshir commented 2 years ago

On Sat, Oct 8 2022 at 11:39:31 PM -07:00:00, Krut Patel @.***> wrote:

Have you verified that all the commands are working fine? I'm not sure how much of the API has changed with v1.

I'm testing these rn... tested run/start/stop

Mubashshir
ahmubashshir commented 2 years ago

I'm not sure how much of the API has changed with v1.

Nothing much, mostly they renamed things here and there, used Enum instead of constants and dropped dependency on clikit, providing their own ui and io modules.

ahmubashshir commented 2 years ago

I'm not sure how much of the API has changed with v1.

Nothing much, mostly they renamed things here and there, used Enum instead of constants and dropped dependency on clikit, providing their own ui and io modules.

edit: the only major incompatibility I noticed is lack of proper table column wrapping.

venv system
venv system
ahmubashshir commented 2 years ago

nah... I'm scrapping this... poetry guys borked cleo so badly that subcommands doesn't work anymore... I'll try something less docs consuming on my end...