iamrasel / lunar-launcher

Feature rich android home with minimal look. 🇵🇸
GNU General Public License v3.0
470 stars 41 forks source link

Screen rotates with rotation active and crashes the app #60

Closed michelevantaggi02 closed 1 year ago

michelevantaggi02 commented 1 year ago

Checklist

App version

2.4

Android version

Android 11 - MIUI 12.5.1

Steps to reproduce the bug

  1. Activate screen rotation
  2. Rotate horizontally
  3. Try a couple of times (it doesn't happen at first try)

Expected behavior

Screen should remain vertical, or it shouldn't crash the home screen

Screenshots/Screen recordings

Screenshot_2023-04-27-09-24-55-006_rasel lunar launcher

Logs

No response

Additional information

No response

iamrasel commented 1 year ago

It doesn't crash for me, i've tried changing the orientation several times. Forcing the view to portrait, wouldn't that be inconvenient for some users?

michelevantaggi02 commented 1 year ago

@iamrasel I don't know why but on the emulator worked fine without crashes, maybe is a problem of miui

michelevantaggi02 commented 1 year ago

I don't think it could be an inconvenient, when it turns horizontal it cuts out most of the interface

iamrasel commented 1 year ago

If it doesn't crash, then letting the user decide their preferred orientation would be helpful. On tablet devices it works fine with landscape mode, the interface don't get cut.

So, I hope it's okay to close this issue and the related PR.