iamsjy17 / Plotta.js

Javascript Functional Graph Library
MIT License
23 stars 5 forks source link

Nice start , but... #5

Open dhiahassen opened 4 years ago

dhiahassen commented 4 years ago

First, I would like to thank you for this open-source effort , second i would like to comment about the fact that there is only one good javascript plot library ( function-plot ) and the rest each is missing some features, after suffering a lot with that fact, I decided to make my own, but it is better to join an open source project, so there I am

I would like to join this project, my initial thoughts are :

we can allow switching internal renderer to support SVG and WebGL

I would like you to provide some description/diagrams for people that want to join the project so that they understand the architecture and they continue from were you possible stop ( trust me found thousands of leftover plotting libraries of javascript form which no one can continue )

Finally, allow me to introduce myself, I have C++/Javascript/Python/Assembly background

Thank you again

iamsjy17 commented 4 years ago

Hi dhiahassen

Thank you for your interest in my project. The answer was late because I found the message late.

Many of your ideas are interesting!!  

const ViewHelperFactory = {
  Create(type) {
    //
    switch (type) {
      case SVG:
        return new SvgHelper();
      case WEBGL:
        return new WebGLHelper();
      case CANVAS:
      default:
        return new CanvasHelper();
    }
  }
};

I think it is very good to use a library to support features like SaveAsSvg / Export2Svg. In fact, we will provide conversion APIs like SaveAsPng and SaveAsPdf.

I would be grateful if you would write description or diagrams.

English is not my main language. There may be some misinterpretations, and if there is anything you need to fix, please advise.

I sincerely welcome you to participate in this project.

You are the first person to raise an issue on my project!! very very thank you :D I appreciate your feedback and will work harder on my project!!

Please contribute to the part you want to contribute according to the commit rules and send a pull request.