iandanforth / pymuscle

A motor unit based model of skeletal muscle and fatigue
Other
64 stars 8 forks source link

Arm curl example #14

Closed iandanforth closed 6 years ago

iandanforth commented 6 years ago

Try to do this without gym dependency.

iandanforth commented 6 years ago

This is now done as part of https://github.com/iandanforth/pymuscle/commit/327902b6a8e70eef8bab90ec18c89f1afb9bf90c

Thinking about this more this example is supposed to be a minimal example in the context of OpenAI Gym. The truly minimal example is the one that lives in the README.

While the example I've implemented mimics some of the API of a gym environment, it's not really a useful starting point to further explore the library or set up more detailed experiments.

Doing this first draft also raised the following important question for the API

When you're dealing with multiple muscles does having a container make sense? Should users just keep instances in a list and then step them all? What about when they need to get the values out of each muscle?

I've added these questions to the Revise API ticket.