ianperrin
commented
2 years ago Hi @BerkSmash1984
Thanks for the detailed report.
Could you try again, but this time set the debug option for the module to true and then capture the output from the logs on the Pi and also from the console in the electron browser?
That might help provide a little more info
Thanks
On 3 May 2022, at 17:38, BerkSmash1984 @.***> wrote:
When submitting a new issue, please supply the following information:
Platform (Hardware/OS): Raspberry Pi 4B, 4GB Raspbian GNU/Linux 10 (buster)
Node Version: v16.15.0
MagicMirror Version: v2.19.0
Description: I am getting client id not authorized, despite having my client ID and client secret correct (from Strava API page). I also have the whitelist setup correctly and can access my MM from my local browser (the MM itself is on a RPI4). I receive the link within the magic mirror and am redirected to the authorization page on Strava, but after clicking authorize and restarting MM, I am still getting the same client ID not authorized. In looking in electron, I do so a ERR_HTTP_HEADERS_SENT error message. Also, I do not see the tokens.json being generated in the MMM-Strava folder after clicking authorize for the Strava auth redirect site Any help would be greatly appreciated. Screenshots below, along with details from Electron for the ERR_HTTP_HEADERS_SENT error
[03.05.2022 10:13.13.537] [ERROR] Whoops! There was an uncaught exception… [03.05.2022 10:13.13.538] [ERROR] Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client at new NodeError (node:internal/errors:371:5) at ServerResponse.setHeader (node:_http_outgoing:576:11) at ServerResponse.header (/home/jberk1984/MagicMirror/node_modules/express/lib/response.js:776:10) at ServerResponse.location (/home/jberk1984/MagicMirror/node_modules/express/lib/response.js:893:15) at ServerResponse.redirect (/home/jberk1984/MagicMirror/node_modules/express/lib/response.js:931:18) at /home/jberk1984/MagicMirror/modules/MMM-Strava/node_helper.js:185:10 at /home/jberk1984/MagicMirror/modules/MMM-Strava/node_helper.js:451:5 at node:fs:2122:7 at FSReqCallback.oncomplete (node:fs:188:23) { code: ‘ERR_HTTP_HEADERS_SENT’
Steps to Reproduce: See screenshots above
Expected Results: functional Strava module in magic mirror
Actual Results: Strava-MMM still stating client ID not authorized when running Magic Mirror
Configuration: What does the used config.js file look like? Don't forget to remove any sensitive information!
Additional Notes: in the MM forums, another poster (sdetweil stated the following:
so, this error is typically caused by some code doing two sends for an incoming request
the module sets up a little server to receive and does a redirect response…
but this could be an async problem start sending one response, continue while it runs and then fall into another send… oops…
I only made a cursory look at the code. i have done similar things in some of my coding here and on other platforms.
I don’t ‘see’ it, but there is a library in there too
this says it is handling a callback on request complete,
line 185 is in the handling of the token auth . but the stravea lib is calling back into the function (function (err, payload, limits) at line 176 so the node_helper called strava, who called us back at the function on line 185 ( (err, data) => { (err, data) => { ) which does a redirect… WHILE the strava request to get the auth token handler is still active…
strava.oauth.getToken(authCode, function (err, payload, limits) { if (err) { console.error(err); res.redirect(
/${self.name}/auth/?error=${err}); return; } // Store tokens self.saveToken(clientId, payload.body, (err, data) => { // line 185 // redirect route res.redirect(/${self.name}/auth/?status=success); }); }); line 451, is in the end of the saveFile() function, supposedly to save the tokens.jsonsaveToken: function (clientId, token, cb) { var self = this; this.readTokens(); // No token for clientId - delete existing if (clientId in this.tokens && !token) { delete this.tokens[clientId]; } // No clientId in tokens - create stub if (!(clientId in this.tokens) && token) { this.tokens[clientId] = {}; } // Add token for client if (token) { this.tokens[clientId].token = token; } // Save tokens to file var json = JSON.stringify(this.tokens, null, 2); fs.writeFile(this.tokensFile, json, "utf8", function (error) { if (error && cb) { cb(error); } if (cb) { cb(null, self.tokens); // line 451 --- this calls back into the ( (err, data) =>) function } })
at FSReqCallback.oncomplete (node:fs:188:23) {
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.
BerkSmash1984
When submitting a new issue, please supply the following information:
Platform (Hardware/OS): Raspberry Pi 4B, 4GB Raspbian GNU/Linux 10 (buster)
Node Version: v16.15.0
MagicMirror Version: v2.19.0
Description: I am getting client id not authorized, despite having my client ID and client secret correct (from Strava API page). I also have the whitelist setup correctly and can access my MM from my local browser (the MM itself is on a RPI4). I receive the link within the magic mirror and am redirected to the authorization page on Strava, but after clicking authorize and restarting MM, I am still getting the same client ID not authorized. In looking in electron, I do so a ERR_HTTP_HEADERS_SENT error message. Also, I do not see the tokens.json being generated in the MMM-Strava folder after clicking authorize for the Strava auth redirect site Any help would be greatly appreciated. Screenshots below, along with details from Electron for the ERR_HTTP_HEADERS_SENT error
[03.05.2022 10:13.13.537] [ERROR] Whoops! There was an uncaught exception… [03.05.2022 10:13.13.538] [ERROR] Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client at new NodeError (node:internal/errors:371:5) at ServerResponse.setHeader (node:_http_outgoing:576:11) at ServerResponse.header (/home/jberk1984/MagicMirror/node_modules/express/lib/response.js:776:10) at ServerResponse.location (/home/jberk1984/MagicMirror/node_modules/express/lib/response.js:893:15) at ServerResponse.redirect (/home/jberk1984/MagicMirror/node_modules/express/lib/response.js:931:18) at /home/jberk1984/MagicMirror/modules/MMM-Strava/node_helper.js:185:10 at /home/jberk1984/MagicMirror/modules/MMM-Strava/node_helper.js:451:5 at node:fs:2122:7 at FSReqCallback.oncomplete (node:fs:188:23) { code: ‘ERR_HTTP_HEADERS_SENT’
Steps to Reproduce: See screenshots above
Expected Results: functional Strava module in magic mirror
Actual Results: Strava-MMM still stating client ID not authorized when running Magic Mirror
Configuration: What does the used config.js file look like? Don't forget to remove any sensitive information!
Additional Notes: in the MM forums, another poster (sdetweil stated the following:
so, this error is typically caused by some code doing two sends for an incoming request
the module sets up a little server to receive and does a redirect response…
but this could be an async problem start sending one response, continue while it runs and then fall into another send… oops…
I only made a cursory look at the code. i have done similar things in some of my coding here and on other platforms.
I don’t ‘see’ it, but there is a library in there too
this says it is handling a callback on request complete,
line 185 is in the handling of the token auth . but the stravea lib is calling back into the function (function (err, payload, limits) at line 176 so the node_helper called strava, who called us back at the function on line 185 ( (err, data) => { (err, data) => { ) which does a redirect… WHILE the strava request to get the auth token handler is still active…
line 451, is in the end of the saveFile() function, supposedly to save the tokens.json
saveToken: function (clientId, token, cb) { var self = this; this.readTokens(); // No token for clientId - delete existing if (clientId in this.tokens && !token) { delete this.tokens[clientId]; } // No clientId in tokens - create stub if (!(clientId in this.tokens) && token) { this.tokens[clientId] = {}; } // Add token for client if (token) { this.tokens[clientId].token = token; } // Save tokens to file var json = JSON.stringify(this.tokens, null, 2); fs.writeFile(this.tokensFile, json, "utf8", function (error) { if (error && cb) { cb(error); } if (cb) { cb(null, self.tokens); // line 451 --- this calls back into the ( (err, data) =>) function } })
at FSReqCallback.oncomplete (node:fs:188:23) {