search

ibhagwan / fzf-lua

Improved fzf.vim written in lua
MIT License
2.38k stars 151 forks source link

Feature: respect `RIPGREP_CONFIG_PATH` by default #1506

Closed looshch closed 1 month ago

looshch commented 1 month ago

Have you RTFM'd?

Feature Request

i think respecting RIPGREP_CONFIG_PATH by default makes more sense since it’s a global, rc-family configuration, so naturally i imagine more people would tend to prefer it to be acknowledged as opposed to explicitly opting into it. If one doesn’t want it, setting it to false or something should do the job. What do you think? Thanks!

ibhagwan commented 1 month ago

We’ve been through this discussion already see #1266, the decision was against this, especially when the workaround is as easy as:

require("fzf-lua").setup({
  grep = {
    RIPGREP_CONFIG_PATH = vim.env.RIPGREP_CONFIG_PATH
  }
})
looshch commented 1 month ago

@ibhagwan yep i know about the workaround, thanks. Sorry for the bother, when checking

  • [X] I have done proper research

i forgot to paste the name of the option into the issues search before opening this one 🤦🏼‍♂️ Apologies!

have a good one

ibhagwan commented 1 month ago

No worries, Ty @looshch for your interest in the project!