refactor(app.js): Migrate to @opentripplanner icons

ibi-group / trimet-mod-otp

5 stars 5 forks source link

refactor(app.js): Migrate to @opentripplanner icons #260

Closed binh-dam-ibigroup closed 4 years ago

binh-dam-ibigroup commented 4 years ago

This PR migrates trimet-mod-otp to use the new @opentripplanner icon sets. What changes (breaking):

The configure() function in config.js now defines:
- A new ModeIcon attribute that sets the icon set for the transit mode selection pane.
- A new LegIcon attribute that replaces applyCustomIconLogic and contains custom logic to determine icons based on travel leg.
The old customIcons are entirely removed.

Now depends on #265 .

binh-dam-ibigroup commented 4 years ago

Also @landonreed or @evansiroky, I had to regenerate yarn.lock or I would get an error involving the moment package. Let me know if you are luckier regarding that.

landonreed commented 4 years ago

CSS issues:

Destination icon is incorrect (should be double ring)

TriMet rose is too large in mode icon

Exclusive modes should be centered

radio button selections are not blue (here and in date/time)

binh-dam-ibigroup commented 4 years ago

That's a caveat of using the OTP-UI library. The default OTP-RR is ported over, so to avoid that you need to compile the desired style into OTP-RR before hand.

landonreed commented 4 years ago

I'm seeing a prop warning when I plan a trip: trip plan

landonreed commented 4 years ago

It looks like the arrow for the collapsible div for walking directions doesn't toggle up/down like it should:

binh-dam-ibigroup commented 4 years ago

@landonreed, I think we have now a pretty good visual parity between the two with my latest changes to https://github.com/opentripplanner/otp-react-redux/pull/150.

landonreed commented 4 years ago

@binh-dam-ibigroup, some more styling issues:

TripSummary has black border (needs to match newplanner.trimet.org)
Itinerary Footer size is too large, links not aligned center
I think we're still waiting on otp-ui icons for the from icon, right?
Itinerary narrative leg header text is too bold.
the bus and streetcar icons in LegIcon/ModeIcon don't appear to match
this is relatively minor (and I won't hold the PR up on this one), but the focus outline on the location field 'x' and icon buttons are a little wonky (should be square):

binh-dam-ibigroup commented 4 years ago

@landonreed, changes to trip summary, itinerary footer, and leg header in narrative are pushed in this commit in otp-react-redux.

binh-dam-ibigroup commented 4 years ago

@landonreed, the last commit in this branch uses StandardModeIconfound on newplanner.trimet.org.

binh-dam-ibigroup commented 4 years ago

Blocked pending action on https://github.com/opentripplanner/otp-react-redux/pull/171.

binh-dam-ibigroup commented 4 years ago

Blocking, awaiting #265.