search

ibis-project / ibis-bigquery

BigQuery backend for Ibis
Apache License 2.0
19 stars 18 forks source link

ci: fixes to address upcoming ibis incompatibilities #106

Closed cpcloud closed 2 years ago

cpcloud commented 2 years ago

This PR is a test of a PR to address the failing ibis master builds here

cpcloud commented 2 years ago

This won't pass until https://github.com/ibis-project/ibis/pull/3240 is merged.

Luckily there's nothing here that requires a major release.

tswast commented 2 years ago

Oops. Looks like it's failing due to some auth issues: https://github.com/ibis-project/ibis-bigquery/runs/4716610653?check_suite_focus=true

Might need to update https://github.com/ibis-project/ibis-bigquery/blob/main/ci/decrypt_secret.sh or more likely https://github.com/ibis-project/ibis-bigquery/blob/main/.github/workflows/system-tests-pr.yml#L58

cpcloud commented 2 years ago

I'll put up a change to revert the environment variable changes.

tswast commented 2 years ago

https://github.com/ibis-project/ibis-bigquery/pull/108 might fix it. I think it has more to do that we're extracting the encrypted secret into the same directory, so we need to update the path for the new location.

tswast commented 2 years ago

Actually maybe not. I see decrypt_secrets.sh uses an absolute path. Reverting those lines should work.