search

ibis-project / ibis-bigquery

BigQuery backend for Ibis
Apache License 2.0
19 stars 18 forks source link

ci: fix environment variable references in system tests #109

Closed cpcloud closed 2 years ago

cpcloud commented 2 years ago

@tswast Is there any reason not to stick the service account JSON creds into a repo secret?

cpcloud commented 2 years ago

I guess the decryption would be the reason at the moment :)

cpcloud commented 2 years ago

Ok, there's an actual bug here! I'll fix it

cpcloud commented 2 years ago

@tswast You're right about the head sha bit. I misread the pull_request_target docs, pull_request_target events run against the base of the pull request which'll be main here.

tswast commented 2 years ago

Looks like it's working now. Thanks! https://github.com/ibis-project/ibis-bigquery/runs/4717044031?check_suite_focus=true

tswast commented 2 years ago

Working in PRs as well: https://github.com/ibis-project/ibis-bigquery/runs/4717105215?check_suite_focus=true