search

ibis-project / ibis-bigquery

BigQuery backend for Ibis
Apache License 2.0
19 stars 18 forks source link

Backend constructor/connect method that supports already-constructed google.cloud.bigquery.Client #128

Open toryhaavik opened 2 years ago

toryhaavik commented 2 years ago

In some cases, it's easier to construct your own bq.Client than delegate to the Backend.connect method. Couldn't there be a factory function and/or Backend constructor that takes an already-created Client?

tswast commented 2 years ago

Thanks for the request! This sounds reasonable to me. I believe the connect method is pretty flexible with regards to the arguments it accepts. I'd be open to a PR that added a bqclient (or similar) keyword argument and bypasses the current client authentication and construction logic.

goodwanghan commented 2 years ago

I am also looking for this feature