ibis-project / ibis-bigquery

BigQuery backend for Ibis
Apache License 2.0
19 stars 18 forks source link

investigate possible regression with latest Ibis #152

Closed tswast closed 1 year ago

tswast commented 1 year ago
tests/system/test_engine.py:4: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
bigframes/engine.py:70: in read_gbq
    table_expression = self.ibis_client.table(parts[2], database=f"{parts[0]}.{parts[1]}")
venv/lib/python3.10/site-packages/ibis_bigquery/__init__.py:185: in table
    t = super().table(name, database=database)
venv/lib/python3.10/site-packages/ibis/backends/base/sql/__init__.py:79: in table
    schema = self.get_schema(qualified_name)
venv/lib/python3.10/site-packages/ibis_bigquery/__init__.py:354: in get_schema
    table_id = self._fully_qualified_name(name, database)
venv/lib/python3.10/site-packages/ibis_bigquery/__init__.py:191: in _fully_qualified_name
    default_project, default_dataset = self._parse_project_and_dataset(database)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <ibis_bigquery.Backend object at 0x7f421b589c90>, dataset = None

    def _parse_project_and_dataset(self, dataset) -> Tuple[str, str]:
        if not dataset and not self.dataset:
>           raise ValueError("Unable to determine BigQuery dataset.")
E           ValueError: Unable to determine BigQuery dataset.

venv/lib/python3.10/site-packages/ibis_bigquery/__init__.py:169: ValueError
cpcloud commented 1 year ago

Should this exist in the main repo now that the bigquery backend has been ported back there?

cpcloud commented 1 year ago

This test does exist there, and master is passing so I don't think it's actually a problem.

tswast commented 1 year ago

I think you're right that this has been fixed in the main ibis repo. I've still got some projects using this package on ibis 3.x, so I'd like to keep this open to backport a fix if it's possible to do so from the ibis-bigquery package.

cpcloud commented 1 year ago

SGTM!

tswast commented 1 year ago

Re-opening just to double-check if this fix is needed in the ibis 4.x repo.