can not use go mod with v4.1.0

romapres2010 commented 5 years ago

I have a problem use go mod with v4.1.0.

First I try go mod tidy. But got only v3.0.0 go: extracting github.com/ibm-messaging/mq-golang v3.0.0+incompatible

Then I edit go mod an replace github.com/ibm-messaging/mq-golang v3.0.0+incompatible to github.com/ibm-messaging/mq-golang/v4 v4.1.0+incompatible

And try go mod tidy again I got an error go: github.com/ibm-messaging/mq-golang/v4@v4.1.0+incompatible: go.mod has non-.../v4 module path "github.com/ibm-messaging/mq-golang" (and .../v4/go.mod does not exist) at revision v4.1.0

ibmmqmet commented 5 years ago

The whole area of Go modules when the tagged version is already greater than 2.0.0 seems problematic. See for example https://github.com/golang/go/issues/25967#issuecomment-422828770 , https://github.com/golang/go/issues/34217 or https://github.com/golang/go/issues/31543

In particular, it seems that adding the new module capabilities are now considered a breaking change because of changes to the import path and would therefore require a new major number for this repository.

I think the best thing to do right now is ignore the module option until

the Go tooling has been improved and stabilised (some things appear to be suggested for Go 14)
older versions of Go that don't understand modules are old enough that they are not in general use
there are other API changes that could deserve a major semver change

romapres2010 commented 5 years ago

I can not ignore module, but I have found workaround.

go get github.com/ibm-messaging/mq-golang/ibmmq@19b946c

After that in in .mod file appeared github.com/ibm-messaging/mq-golang v1.0.1-0.20190820103725-19b946c185a8

For now that is works well for me.

ibm-messaging / mq-golang

can not use go mod with v4.1.0 #121