search

ibpsa / modelica-ibpsa

Modelica library for building and district energy systems developed within IBPSA Project 1
https://ibpsa.github.io/project1
143 stars 84 forks source link

Update BESTEST cases according to ASHRAE 140-2020 #1750

Open JayHuLBL opened 1 year ago

JayHuLBL commented 1 year ago

This issue is to update the BESTEST cases defined in ASHRAE 140-2020. It will include the changes that can be found from Modelica Buildings Library Issue 3005.

The new test acceptance criteria, which were published in ASHRAE 140-2020 Addendum b, will also be included in the cases.

JayHuLBL commented 1 year ago

@amaccarini The ASHRAE 140-2020 has some changes different from the version 2017. Please see the documented list in Building library issue3005. In branch issue1750_updateBESTEST_models, I have updated the weather file and also updated the maximum and minimum values. However, since the test models here are lumped models, I am not sure how we can update the models accordingly.

amaccarini commented 1 year ago

@JayHuLBL Thanks for your message. I am still working on the BESTEST validation for IBPSA.ThermalZone.ISO13790 in order to update the results. I haven't had time to work on this issue yet, but I am planning to look into that during the summer. I will keep you posted! Perhaps we could arrange a quick call to coordinate. I think I need some inputs about the python file you created for the Buildings library to automatically compare the BESTEST results. The idea is to make a similar file for the IBPSA library.