icecube / skymap_scanner

A distributed system that performs a likelihood scan of event directions for IceCube real-time alerts using CPU cluster(s) and queue-based message passing.
5 stars 2 forks source link

Refactor prepare_frame_packet #260

Open tianluyuan opened 6 months ago

tianluyuan commented 6 months ago

The function prepare_frame_packet in extract_json_message.py consists of many moving parts and changes to state. One example, mentioned in #244 is the call to prepare_frames(frame_packet, ...) which modifies and returns an updated list of frames. We should try to simplify / clean up this function.

ric-evans commented 6 months ago

link: https://github.com/icecube/skymap_scanner/pull/244#discussion_r1445044023

mlincett commented 6 months ago

I had outlined some ideas about this in #149 , but then abandoned that path.