don't pull in `futures-executor` when it's not the default executor

iced-rs / iced

A cross-platform GUI library for Rust, inspired by Elm

https://iced.rs

MIT License

26.34k stars 1.28k forks source link

don't pull in `futures-executor` when it's not the default executor #2841

Closed edwloef closed 2 weeks ago

edwloef commented 1 month ago

This avoids the need to pull in futures-executor when a different default executor is chosen. I've verified that app startup still works on all native executors. Hopefully I chose the correct approach.

futures-executor won't actually not be pulled in until https://github.com/hecrj/sipper/pull/1 is included as well

edwloef commented 1 month ago

well, wasm-bindgen-futures was being annoying but it passes now. :shrug:

edwloef commented 2 weeks ago

You may need to enable the async-await feature of futures in iced-futures.

hecrj commented 2 weeks ago

I just did in 5d1de9dc95bd981be122f6442d7d77de80d5d176.

edwloef commented 2 weeks ago

Yeah, I saw, I was just barely too late :sweat_smile:

karolisr commented 2 weeks ago

Hmm, I do not understand why, but after this merge some examples compiled with "tiny-skia" disabled and "wgpu" backend enabled do not work (at least on macOS). "todos" example does work. "arc" and "bezier-tool" do not. They compile, but no window opens and program exits. I tried with "thread-pool", "tokio", and "smol". No go. Any ideas what's going on?

karolisr commented 2 weeks ago

Ignore previous comment. Fixed in: 1b22d7d5fcdf519a3cac7a3cfd14398a3108c3b8

Hmm, I do not understand why, but after this merge some examples compiled with "tiny-skia" disabled and "wgpu" backend enabled do not work (at least on macOS). "todos" example does work. "arc" and "bezier-tool" do not. They compile, but no window opens and program exits. I tried with "thread-pool", "tokio", and "smol". No go. Any ideas what's going on?