search

icedman / search-light

Gnome Extension to bring macOS's Spotlight functionality
GNU General Public License v3.0
391 stars 23 forks source link

Searchlight causes gnome to crash if used first after boot #82

Open kugelvlitz opened 5 months ago

kugelvlitz commented 5 months ago

If I use search-light after logging in into a new session, right after boot, Gnome will crash and send me back to GDM. If I log back in all extensions will be disabled.

This only occurs in that specific scenario, otherwise it works fine.

I'm using Gnome 46 on ArchLinux, although this bug also occurred to me in 45.

muerwre commented 4 months ago

Experiencing the same on manjaro. Probable journalctl /usr/bin/gnome-shel output:

clutter_actor_set_mapped: assertion '!CLUTTER_ACTOR_IN_MAP_UNMAP (self)' failed
**
Clutter:ERROR:../mutter/clutter/clutter/clutter-actor.c:1946:clutter_actor_real_unrealize: assertion failed: (!clutter_actor_is_mapped (self))
Bail out! Clutter:ERROR:../mutter/clutter/clutter/clutter-actor.c:1946:clutter_actor_real_unrealize: assertion failed: (!clutter_actor_is_mapped (self))
== Stack trace for context 0x643fdb18e8e0 ==
   643fdb25a1b0 i   file:///home/user/.local/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:665 (3a11820ee9c0 @ 60)
   643fdb25a120 i   file:///home/user/.local/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:450 (3a11820ee600 @ 28)
  643fdb25a090 i   file:///home/user/.local/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:908 (3a11820eed80 @ 284)
  643fdb25a000 i   file:///home/user/.local/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:665 (3a11820ee9c0 @ 60)
  643fdb259f70 i   file:///home/user/.local/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:450 (3a11820ee600 @ 28)
  643fdb259ee8 i   file:///home/user/.local/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:937 (3a11820eee70 @ 17)
  643fdb259e58 i   resource:///org/gnome/shell/ui/init.js:21 (1969b2e70bf0 @ 48)
muerwre commented 4 months ago

It is caused by this string:

665 | this._entry.get_parent().remove_child(this._entry);

I can see at string no 633 that this._entry.get_parent() should be checked before calling remove_child on it?

633 |    if (this._entry.get_parent()) {
634 |       this._entry.get_parent().remove_child(this._entry);
635 |    }
icedman commented 4 months ago

Added parent check (although I wasn't able to recreate this crash)

sqwxl commented 2 months ago

Can confirm I'm seeing the same on version 27 of this extension with Fedora 40 & Gnome 46.2 Some more log context, in this example the crash happened when starting Slack a few seconds after login, but the bug appears to happen regardless of the application launched:

Aug 07 08:45:24 blackbox gnome-shell[10030]: invalid (NULL) pointer instance
Aug 07 08:45:24 blackbox gnome-shell[10030]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
# ...
Aug 07 08:45:24 blackbox gnome-shell[10030]: invalid (NULL) pointer instance
Aug 07 08:45:24 blackbox gnome-shell[10030]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
# ...
Aug 07 08:45:30 blackbox systemd[9587]: Started app-gnome-com.slack.Slack-12390.scope - Application launched by gnome-shell.
Aug 07 08:45:31 blackbox systemd[9587]: Started app-flatpak-com.slack.Slack-12390.scope.
# ...
Aug 07 08:45:32 blackbox gnome-keyring-daemon[9654]: asked to register item /org/freedesktop/secrets/collection/login/3, but it's already registered
Aug 07 08:45:32 blackbox com.slack.Slack.desktop[12559]: LaunchProcess: failed to execvp:
Aug 07 08:45:32 blackbox com.slack.Slack.desktop[12559]: xdg-settings
Aug 07 08:45:32 blackbox gnome-shell[10030]: clutter_actor_set_mapped: assertion '!CLUTTER_ACTOR_IN_MAP_UNMAP (self)' failed
Aug 07 08:45:32 blackbox gnome-shell[10030]: **
Aug 07 08:45:32 blackbox gnome-shell[10030]: Clutter:ERROR:../clutter/clutter/clutter-actor.c:1946:clutter_actor_real_unrealize: assertion failed: (!clutter_actor_is_mapped (self))
Aug 07 08:45:32 blackbox gnome-shell[10030]: Bail out! Clutter:ERROR:../clutter/clutter/clutter-actor.c:1946:clutter_actor_real_unrealize: assertion failed: (!clutter_actor_is_mapped (self))
Aug 07 08:45:32 blackbox gnome-shell[10030]: == Stack trace for context 0x55773b539190 ==
Aug 07 08:45:32 blackbox gnome-shell[10030]: #0   55773b600b20 i   file:///usr/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:459 (37551311aba0 @ 60)
Aug 07 08:45:32 blackbox gnome-shell[10030]: #1   55773b600a90 i   file:///usr/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:272 (37551311a830 @ 28)
Aug 07 08:45:32 blackbox gnome-shell[10030]: #2   55773b600a00 i   file:///usr/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:673 (37551311af60 @ 284)
Aug 07 08:45:32 blackbox gnome-shell[10030]: #3   55773b600970 i   file:///usr/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:459 (37551311aba0 @ 60)
Aug 07 08:45:32 blackbox gnome-shell[10030]: #4   55773b6008e0 i   file:///usr/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:272 (37551311a830 @ 28)
Aug 07 08:45:32 blackbox gnome-shell[10030]: #5   55773b600858 i   file:///usr/share/gnome-shell/extensions/search-light@icedman.github.com/extension.js:702 (3755131280b0 @ 17)
Aug 07 08:45:32 blackbox gnome-shell[10030]: #6   55773b6007c8 i   resource:///org/gnome/shell/ui/init.js:21 (1b3ecf770bf0 @ 48)
Aug 07 08:45:32 blackbox audit[10030]: ANOM_ABEND auid=1000 uid=1000 gid=1000 ses=3 subj=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 pid=10030 comm="gnome-shell" exe="/usr/bin/gnome-shell" sig=6 res=1
Aug 07 08:45:32 blackbox systemd[1]: Created slice system-systemd\x2dcoredump.slice - Slice /system/systemd-coredump.
Aug 07 08:45:32 blackbox audit: BPF prog-id=84 op=LOAD
Aug 07 08:45:32 blackbox audit: BPF prog-id=85 op=LOAD
Aug 07 08:45:32 blackbox audit: BPF prog-id=86 op=LOAD
Aug 07 08:45:32 blackbox systemd[1]: Started systemd-coredump@0-12606-0.service - Process Core Dump (PID 12606/UID 0).
Aug 07 08:45:32 blackbox audit[1]: SERVICE_START pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='unit=systemd-coredump@0-12606-0 comm="systemd" exe="/usr/lib/systemd/systemd" h>
Aug 07 08:45:34 blackbox systemd-coredump[12608]: Process 10030 (gnome-shell) of user 1000 dumped core.
muerwre commented 1 month ago

Yeah, still facing issue, also with slack most of the times, when launching it after a few seconds after login.