icefoganalytics / travel-authorization

0 stars 0 forks source link

Issue-230: Travel Desk Rank Travel Options – Make Travel Request Process More Linear #238

Closed klondikemarlen closed 3 days ago

klondikemarlen commented 1 week ago

Relates to:

Context

After a brief time away from the Travel Authorization project, I couldn't remember the process to complete a travel request. Since I'm the primary developer on this project, I concluded that the process is simply too hard to understand in its current state. This PR attempts to make the process more linear and self explanatory.

Implementation

Rework travel authorization request in wizard pattern.

Screenshots

Initial steps broken out for simpler logic and to make it easier to understand what you need to do image

Trip details now a separate page image

Estimate generation now its own page, so non-linear page flow is now linear image

Review and submit page image

Submit page with validation failed image

Review travel request page, with revert to draft option on "back" image

Review estimate page image

Waiting for approval page, with option to jump back to review details or estimate image

Pretty much full steps list image

Testing Instructions

  1. Run the test suite via dev test (or dev test_api)
  2. Boot the app via dev up
  3. Log in to the app at http://localhost:8080
  4. Click on the "New Travel Request" button at the bottom of the dashboard.
  5. Follow the steps in the wizard.
  6. Log in as the user your supervisor user, and approve the request.
  7. Log back in as your traveler.
  8. Check that you can now enter your travel details.
  9. Log in as your travel desk user.
  10. Using steps from https://github.com/icefoganalytics/travel-authorization/pull/237 try to enter some request options.

    This probably will not work. I need to rebuild the option generation code as it is very unpredictable.