icerockdev / moko-errors

Automated exceptions handler for mobile (android & ios) Kotlin Multiplatform development.
https://moko.icerock.dev/
Apache License 2.0
52 stars 6 forks source link

UIViewController not deinit if was binded to ExceptionHandler #18

Open Dorofeev opened 3 years ago

Dorofeev commented 3 years ago

Here the branch with reproducer. UIViewController not deinited after deleting from navigation stack, if it was binded by viewModel.exceptionHandler.bind(viewController: self)

Alex009 commented 1 year ago

i see that now UIViewController stored in weak reference

https://github.com/icerockdev/moko-errors/blob/f1d29f93f6f67049c19a574c330a0e9877346e74/errors/src/iosMain/kotlin/dev/icerock/moko/errors/handler/ExceptionHandlerBinder.kt#L36

can be bug outdated?