ices-eg / wg_WGACOUSTICGOV

Working Group on Acoustic Trawl Data Portal Governance
http://ices.dk/community/groups/Pages/WGacousticgov.aspx
5 stars 1 forks source link

Check acoustic files are sorted by log distance? #17

Closed HjalteParner closed 2 years ago

HjalteParner commented 3 years ago

After DE upload of BASS survey 2020 - LogDistance was wrong and it went through anyway making the map look like this:

image

Acoustic files are stored as received. Should we add check to enforce that acoustic files are sorted by log distance?

Should we also check acoustic log distance increases with with log time?

HjalteParner commented 3 years ago

Implemented - submitted acoustic files doesn't need to be sorted in order to validate, however a check have been added to make sure log distance increase with log time.

Mackinson commented 2 years ago

Inconsistency reporting ‘Log Distance should increase with Log Time '2020-09-02T23:57:00'. The assumption that the log distance will increase at all times is correct. It is not however correct that Log time should increase with log distance because of the way transects can be sequenced during processing. As implemented, the rule that log time should increase with log distance is incorrectly picking up faults that are real. The simple rule should be that log distance should increase. It two do not need to be contingent on one another.