ices-tools-dev / esas

European Seabirds at Sea (ESAS) data model
https://esas-docs.ices.dk
Creative Commons Zero v1.0 Universal
3 stars 1 forks source link

Disclaimer in download #111

Closed nicolasvanermen closed 2 years ago

nicolasvanermen commented 2 years ago
peterdesmet commented 2 years ago

I assume these are typos/suggestions for the disclaimer.txt file that is included in a download. @neil-ices-dk can you correct these or is this something for @cmspinto?

neil-ices-dk commented 2 years ago

edit: (description on this link: http://datsu.ices.dk/web/selRep.aspx?Dataset=148)

the typo in the dataset name has been forwarded to the vocab management group for correcting

edit: (description on this link: http://datsu.ices.dk/web/selRep.aspx?Dataset=148)

do you want the description to be the full text from the landing page? https://www.ices.dk/data/data-portals/Pages/European-Seabirds-at-sea.aspx

edit: better to move "Documentation can be found at https://esas-docs.ices.dk/" to section 3

this was previously moved from section 3 to gather the links in one section and a pointer made in section 3 to avoid repetition: Information about the ESAS data and formats can be found in the links in section 7.

nicolasvanermen commented 2 years ago

There are two links in section 3 already... so still preferring the https://esas-docs.ices.dk/ in section 3 as well.

nicolasvanermen commented 2 years ago

Regarding the 2nd bullet, the link should only be between brackets: The Download ZIP bundle includes the requested data file in the CSV format (description on this link: http://datsu.ices.dk/web/selRep.aspx?Dataset=148), and the data disclaimer.
...instead of... The Download ZIP bundle includes the requested data file in the CSV format (description on this link) http://datsu.ices.dk/web/selRep.aspx?Dataset=148, and the data disclaimer.

neil-ices-dk commented 2 years ago

typo corrected in vocab; @nicolasvanermen it would be easier if you go and make the edits on the disclaimer yourself and then just ping Carlos who will upload the final version - thanks https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download

nicolasvanermen commented 2 years ago

OK tried to do so, the first commit gave some sort of warning though:

image

peterdesmet commented 2 years ago

@nicolasvanermen you can ignore the warning you got: your next commit got a ✔️ meaning that the website (https://esas-docs.ices.dk/) was built successfully.

neil-ices-dk commented 2 years ago

@cmspinto to pull into the esas app

cmspinto commented 2 years ago

Disclaimer updated, could someone `have a look?

neil-ices-dk commented 2 years ago

@cmspinto yes the disclaimer matches, there is one issue though in section 6

Additionally, if the download is predominantly from one or two data providers, please directly acknowledge the data source(s) when using the data: XXXXXXXXXXXXXXXXXXXX

Where XXXX was supposed to be filled with all the DataRightsHolder(s) (edit Nicolas:)in the download

peterdesmet commented 2 years ago

I have updated the disclaimer document at https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download. Note that it includes a number of whitespace changes that I think make the text easier to read, so please replace the entire disclaimer.

I have also updated the citation sentence (and citation cf. the homepage) to:

The recommended citation is:

European Seabirds At Sea (ESAS) (2022). ICES, Copenhagen. https://esas.ices.dk

If the download is predominantly from one or two data providers, please acknowledge them directly as well. The following data providers contributed to the download:

XXXXXXXXXXXXXXXXXXXX

nicolasvanermen commented 2 years ago

I have a long history of misinterpreting this specific issue, but as far as I understand now XXXXXXXXX will be a tailored list of data providers included in the download, and this is what will be implemented. Correct me if I am wrong again...

peterdesmet commented 2 years ago

but as far as I understand now XXXXXXXXX will be a tailored list of data providers included in the download

Yes, that is how I understood it too.

neil-ices-dk commented 2 years ago

@cmspinto to include the data providers to each disclaimer (the XXXXX bit)

cmspinto commented 2 years ago

Haven't publish yet, will do tomorrow (28/10/2022) but the citation will look like this:

image

Disclaimer: image

nicolasvanermen commented 2 years ago

The current disclaimer in the download includes the institutes names, yet is not the same as the one reviewed by Peter: https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download. So parallel versions are circulating apparently...

cmspinto commented 2 years ago

Have updated the disclaimer to be this one: https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download

nicolasvanermen commented 2 years ago

Beautiful, closing this issue.