Open d-wells opened 5 years ago
I'm submitting a new pull request as D-Wells original suggestion has vanished from the internet. I don't know what d-wells specifically changed but I'm assuming the changes I've put in is pretty close to what D-Wells suggested, based on what I could clean from d-wells' comment above without ever seeing the specific changes.
https://github.com/icfnext/cq-component-maven-plugin/pull/94/commits
When setting useCoral3Dialogs=true configuration for the cq-component-maven-plugin, existing Tab inclusions, via @Tab(touchUIPath=...) stop working.
The issue is that the path property does not get written to the xml node corresponding to the item node with sling:resourceType granite/ui/components/foundation/include, e.g. (with 6.4.1-SNAPSHOT)
I've confirmed this behavior in 6.0.0, 6.1.0, 6.4.0, and develop (6.4.1-SNAPSHOT).
Issue appears to have been introduced in com.citytechinc.cq.component.touchuidialog.layout.tabs.TabsLayoutCoral3Maker, commit # e4989ad10f6febc3f461a7c2ccc23359f945b7b1, with the change from
to
FixedColumnsLayoutElement class includes a getPath() method. Container class does not have a getPath() method.
That method is critical for the XMLWriter when determining what xml attributes / node properties are applicable for the current element.
Based on the last several months of commits, it looks like there's an effort to move completely to containers for 6.3+, due to the increased coral3 dialog usage, so instead of suggesting a reversion of e4989ad10f6febc3f461a7c2ccc23359f945b7b1, I'm suggesting an update to com.citytechinc.cq.component.touchuidialog.container.Container and com.citytechinc.cq.component.touchuidialog.container.Section.
See https://github.com/d-wells/cq-component-maven-plugin/pull/1/commits